search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Fix overload of `getindex` #152

Closed omus closed 4 years ago

omus commented 4 years ago

An old deprecation was left in Memento which defines its own getindex function:

julia> using Memento

julia> getindex
WARNING: both Memento and Base export "getindex"; uses of it in module Main must be qualified
ERROR: UndefVarError: getindex not defined

Was introduced here: https://github.com/invenia/Memento.jl/commit/44cd87a4a4f3e6ec2c88cadbd3d3ae0a9b1397dc#diff-74d7f3cb64eee8b5198817d9027172f7L14

codecov[bot] commented 4 years ago

Codecov Report

Merging #152 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          12       12           
  Lines         316      316           
=======================================
  Hits          305      305           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 609a9fc...7c6d0f2. Read the comment docs.