search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Drop deprecations and prep 1.0 release #154

Closed rofinn closed 4 years ago

rofinn commented 4 years ago

Closes #144

codecov[bot] commented 4 years ago

Codecov Report

Merging #154 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          12       12           
  Lines         316      316           
=======================================
  Hits          305      305           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d0e95c...dc002ca. Read the comment docs.

rofinn commented 4 years ago

No, I think I've either merged or postponed any remaining work. I'll get a rough implementation of #155 working before merging, but I think that can be included in a minor release after.

oxinabox commented 4 years ago

Yes, I think this should be merged before #155. I think its good not to introduce new features in what would otherwise be a change characterized only by dropping deprecations.

It feels right that the 1.0 release should differ from last pre1.0 release only in dropping deprecations?

rofinn commented 4 years ago

Yeah, I just wanted to make sure that the Escalator solution would work without any breaking API changes (not that I really thought it would). Merging.