Closed rofinn closed 4 years ago
This came up while debugging #159 where the Main
logger on the REPL wasn't registered, but the inner Example logger was. I suppose Memento._logger
should just be a tree at some point to ensure that parents exist, but that seemed like more work.
Merging #160 into master will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 96.97% 96.99% +0.01%
==========================================
Files 12 12
Lines 331 333 +2
==========================================
+ Hits 321 323 +2
Misses 10 10
Impacted Files | Coverage Δ | |
---|---|---|
src/loggers.jl | 99.09% <100.00%> (+0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fa94fea...9c95f57. Read the comment docs.
In some cases, you may end up registering a nested logger without the parent being registered. In these cases, we should autoregister the parent if it doesn't exist... otherwise it can lead to confusing behaviour.