search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

TimeZones Dependency #161

Closed ccoffrin closed 4 years ago

ccoffrin commented 4 years ago

Might it be possible to drop the dependency on TimeZones? It's build process has been problematic from time to time and it pulls down this file "https://data.iana.org/time-zones/releases/tzdata2019c.tar.gz" which represents non-github hosted data that isn't tracked by the Julia package manager.

rofinn commented 4 years ago

I'll redirect this to @omus. I feel like the TimeZones.jl build process should just be fixed. Otherwise, it's a pretty light package... and we do find it helpful to have timezone aware timestamps. There has been a discussion of providing a Minimento.jl (for lack of a better name) package that doesn't have any dependencies, but I think at that point it'd be better to just add the functionality we want to the Logging stdlib.

omus commented 4 years ago

I've been thinking about using Julia artifacts to store the tzdata which would also address this problem. Out of curiosity, what is problematic about the build process?

ccoffrin commented 4 years ago

Over the years it was breaking from time to time, I think the wget/curl call would break due to some proxy issue on my side, which was breaking and fixed at random.

A big advantage of a github-only solution is that the git protocol can be used to pull down all of the data which is friendly with various proxies and filters that I encounter.

ccoffrin commented 4 years ago

If Julia artifacts is a viable solution, that sounds good to me!

racinmat commented 4 years ago

TimeZones now use Artifacts https://github.com/JuliaTime/TimeZones.jl/releases/tag/v1.3.0

rofinn commented 4 years ago

Looks like we should already support that version, so I’ll close this. Please re-open if you run into further issues.

ccoffrin commented 4 years ago

Thanks!!!