search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Add thread id attribute to the DefaultRecord #177

Closed arnaudh closed 3 years ago

arnaudh commented 3 years ago

To help debug multi-threaded code.

Seems pretty fast so low overhead:

julia> @btime Threads.threadid()
  2.800 ns (0 allocations: 0 bytes)
1
codecov[bot] commented 3 years ago

Codecov Report

Merging #177 (3489dbe) into master (00c6686) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          13       13           
  Lines         396      396           
=======================================
  Hits          389      389           
  Misses          7        7
Impacted Files Coverage Δ
src/records.jl 94.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00c6686...3489dbe. Read the comment docs.

arnaudh commented 3 years ago

Updated tests and squashed commits.

rofinn commented 3 years ago

Don't forget to bump the minor release since this is technically a new feature :)