search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Reroute `nothing` stdlib `mod` to the root logger #185

Closed rofinn closed 2 years ago

rofinn commented 2 years ago

Closes #181

NOTE: This seems more internally consistent than having a separate logger for this case?

codecov[bot] commented 2 years ago

Codecov Report

Merging #185 (ecb6faa) into master (eccf67a) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   98.30%   98.26%   -0.04%     
==========================================
  Files          14       14              
  Lines         413      404       -9     
==========================================
- Hits          406      397       -9     
  Misses          7        7
Impacted Files Coverage Δ
src/stdlib.jl 100.00% <100.00%> (ø)
src/formatters.jl 98.03% <0.00%> (-0.04%) :arrow_down:
src/loggers.jl 99.26% <0.00%> (-0.04%) :arrow_down:
src/io.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eccf67a...ecb6faa. Read the comment docs.

arnaudh commented 2 years ago

Thanks! Looks good to me. Can't approve as I don't have write access.

mjram0s commented 2 years ago

Should add a test

rofinn commented 1 year ago

TODO: We should probably backport this fix since CloudWatchLogs has upperbounded things to 1.2.

arnaudh commented 1 year ago

TODO: We should probably backport this fix since CloudWatchLogs has upperbounded things to 1.2.

Ah yes, that's probably the easiest to deal with our issues. Will do that.

EDIT here: https://github.com/invenia/Memento.jl/pull/190