Backport stdlib mod nothing

[arnaudh]

Backport of https://github.com/invenia/Memento.jl/pull/185/ for the 1.2.0 branch (which I created from the v1.2.0 tag for the occasion - let me know if that's not the right process).

This is so that CloudWatchLogs can pull in the fix (there Memento is upper-bounded to 1.2 due to date representation differences).

[codecov[bot]]

Codecov Report

Merging #190 (1844a4f) into backport-v1.2.0 (00c6686) will decrease coverage by 0.24%. The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           backport-v1.2.0     #190      +/-   ##
===================================================
- Coverage            98.23%   97.98%   -0.25%     
===================================================
  Files                   13       13              
  Lines                  396      397       +1     
===================================================
  Hits                   389      389              
- Misses                   7        8       +1     

Impacted Files	Coverage Δ
src/stdlib.jl	100.00% <100.00%> (ø)
src/records.jl	91.17% <0.00%> (-2.95%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[iamed2]

I think typically the Julia community would name the branch release-1.2. No problem with this for now, the three of us can just remember this is where it is.

[rofinn]

FWIW, we usually git cherry-pick our commits to apply backports. This helps to keep the history clearer and means that git blame will correctly identify the person you should talk to. In this case, it's a pretty minor change so it shouldn't matter too much.

[arnaudh]

How do we register this new 1.2.1 version?

I had a guess and triggered the TagBot actions on the backport branch (https://github.com/invenia/Memento.jl/actions/runs/3242019552), but the output says Tag v1.4.1 already exists so doesn't look like it picked up the right toml.

[iamed2]

@arnaudh you do so through a comment, like this: https://github.com/invenia/Memento.jl/commit/c03bd20a1aa911cd3e8297456884d50dd9ed418d#commitcomment-86699867

[arnaudh]

@JuliaRegistrator register

[JuliaRegistrator]

Error while trying to register: Register Failed @arnaudh, it looks like you are not a publicly listed member/owner in the parent organization (invenia). If you are a member/owner, you will need to change your membership to public. See GitHub Help

[arnaudh]

@JuliaRegistrator register

[JuliaRegistrator]

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

[arnaudh]

Thanks, now I know (and have made my membership to Invenia public so I can do it next time). I see @BaileyBox did it for this MR, thanks! https://github.com/invenia/Memento.jl/commit/e398beb0050cdb2613bfb0bfe0a7a6e0ade705be#commitcomment-86609403

[iamed2]

@arnaudh no, I did it for this PR, in the comment I linked above. Bailey's was for a different PR.