search

invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
88 stars 14 forks source link

Silence logging test macros #71

Closed rofinn closed 6 years ago

rofinn commented 6 years ago

@test_log and related functions should be properly disabled while running the testing code. This includes dropping any existing handlers and not allowing the logger to propagate.

codecov[bot] commented 6 years ago

Codecov Report

Merging #71 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         224    232    +8     
=====================================
+ Hits          224    232    +8
Impacted Files Coverage Δ
src/test.jl 100% <100%> (ø) :arrow_up:
src/loggers.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acdc366...979459d. Read the comment docs.

iamed2 commented 6 years ago

This is just for Memento's tests?

rofinn commented 6 years ago

Yes, any time you use Memento's test macros we should be temporarily disabling message from the logger passed in.