invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
88 stars 14 forks source link

More 0.7 updates #79

Closed rofinn closed 6 years ago

rofinn commented 6 years ago
codecov[bot] commented 6 years ago

Codecov Report

Merging #79 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #79   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         251    251           
=====================================
  Hits          251    251
Impacted Files Coverage Δ
src/loggers.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6f26e7...8937beb. Read the comment docs.

rofinn commented 6 years ago

I'm not sure why Pkg.build is returning 1 now.

ararslan commented 6 years ago

I'd actually hold off on any Pkg-related changes on 0.7. Enough compatibility shims are in place that things should continue to work as expected without a project file.

rofinn commented 6 years ago

I'd like to have a Project.toml file though, so that I can use instantiate from the cloned repo. Maybe there is a better middle ground though? I noticed that the Comapt Project.toml was renamed.

ararslan commented 6 years ago

Compat's Project.toml file was renamed to effectively disable it since it was causing problems. As I understand it, for everything to work properly with Pkg3, every package in the dependency tree for a given package needs to have a Project.toml file. But since Compat's is disabled, that's kind of a non-starter until it's reinstated, as Compat is used by basically every package that supports 0.7.