invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
88 stars 14 forks source link

Store dates in UTC but print them in local time #94

Closed iamed2 closed 6 years ago

iamed2 commented 6 years ago
codecov[bot] commented 6 years ago

Codecov Report

Merging #94 into master will decrease coverage by 1.04%. The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   98.92%   97.87%   -1.05%     
==========================================
  Files          11       11              
  Lines         278      283       +5     
==========================================
+ Hits          275      277       +2     
- Misses          3        6       +3
Impacted Files Coverage Δ
src/Memento.jl 100% <ø> (ø) :arrow_up:
src/records.jl 100% <100%> (ø) :arrow_up:
src/formatters.jl 94% <57.14%> (-6%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 232bc2a...3a63b4a. Read the comment docs.

rofinn commented 6 years ago

Hmmm, is the coverage drop just continued issues with coverage reporting?

ararslan commented 6 years ago

Yeah, looking at the Codecov report on their website, the change in coverage looks bogus.

iamed2 commented 6 years ago

Yeah it's unfortunate but I can't see how this isn't just a random bug. Unrelated to previous issues though, as those were about 0.7 reporting bad coverage.

rofinn commented 6 years ago

Okay, this looks good to me.