invenia / Memento.jl

A flexible logging library for Julia
https://invenia.github.io/Memento.jl/latest
Other
87 stars 14 forks source link

Fixed broken stacktrace behaviour #99

Closed rofinn closed 6 years ago

rofinn commented 6 years ago

Closes #96

codecov[bot] commented 6 years ago

Codecov Report

Merging #99 into master will decrease coverage by 1.4%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   98.94%   97.53%   -1.41%     
==========================================
  Files          11       11              
  Lines         284      284              
==========================================
- Hits          281      277       -4     
- Misses          3        7       +4
Impacted Files Coverage Δ
src/loggers.jl 100% <100%> (ø) :arrow_up:
src/stdlib.jl 12.5% <0%> (-50%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 441189d...627b5d0. Read the comment docs.

iamed2 commented 6 years ago

Good solution, I agree that handlers can be responsible for their own async