Closed sdl1 closed 4 years ago
Merging #16 into master will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 3 3
Lines 73 73
=======================================
Hits 68 68
Misses 5 5
Impacted Files | Coverage Δ | |
---|---|---|
src/test_utils.jl | 92.53% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5506930...5793dbf. Read the comment docs.
docstring for test_interface
says:
Returns the predictions of the
Model`.
However, I checked all packages that i know of that use Models.jl and none of them actually use this feature anymore.
I think should remove that docstring, and tag a breaking release.
Technically, you could rely on that feature right now, its just that your tests wouldn't work so great.
Cool, I removed the docstring and changed the version to be breaking
Cool. merge then register release. Registrering a release on github is done by following these instructions. We have the Registrator app installed already.
Closes #15
Gives correct behaviour in the following situation: