search

invenia / Models.jl

An interface package that defines the methods and types for working with models.
MIT License
3 stars 0 forks source link

Add PredictInputTrait to Models API #28

Closed BSnelling closed 3 years ago

BSnelling commented 3 years ago

Experimenting with adding an InputTrait to the Models API. The use case for this trait would be for models that can accept distributions as inputs to the predict step.

Questions for discussion:

  1. Is it bad that this InputTrait would refer to inputs specifically to predict? Would this cause confusion if for some reason we wanted to use distribution inputs to fit in the future?
  2. Can this be done in a non-breaking way?
codecov[bot] commented 3 years ago

Codecov Report

Merging #28 (7b156e3) into master (857af7d) will decrease coverage by 0.56%. The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   94.04%   93.47%   -0.57%     
==========================================
  Files           3        3              
  Lines          84       92       +8     
==========================================
+ Hits           79       86       +7     
- Misses          5        6       +1
Impacted Files Coverage Δ
src/traits.jl 87.50% <75.00%> (-12.50%) :arrow_down:
src/Models.jl 100.00% <100.00%> (ø)
src/test_utils.jl 93.82% <100.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 857af7d...9252321. Read the comment docs.