invenia / Models.jl

An interface package that defines the methods and types for working with models.

MIT License

3 stars 0 forks source link

Fix Travis matrix/jobs conflict #6

Closed iamed2 closed 4 years ago

iamed2 commented 4 years ago

This seems to come up some times but not others. Travis has made it so if you have both matrix and jobs, jobs is discarded. I don't know why. In any case, the modern way is to never use matrix for anything.

codecov[bot] commented 4 years ago

Codecov Report

Merging #6 into master will not change coverage by %. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files           3        3           
  Lines          67       67           
=======================================
  Hits           61       61           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 384d219...1cc4313. Read the comment docs.

codecov[bot] commented 4 years ago

Codecov Report

Merging #6 into master will not change coverage by %. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files           3        3           
  Lines          67       67           
=======================================
  Hits           61       61           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03c11c7...68a15d9. Read the comment docs.

iamed2 commented 4 years ago

I've added back the codecov requirement since everything seems to be working again

iamed2 commented 4 years ago

@glennmoy You don't need to unapprove when the build is failing if the build succeeding is a requirement for merge

nickrobinson251 commented 4 years ago

Thanks @iamed2 !