search

invenia / ObservationDims.jl

Traits for specifying the orientation of features and observations in data
MIT License
2 stars 1 forks source link

Add Tables support #15

Closed oxinabox closed 4 years ago

oxinabox commented 4 years ago

This closes #14

An issue is, because Table is not a type can't dispatch on it. so we wrap it in a _TableHolder for dispatch purposes.

One assumption this code makes is that a a table is never a AbstractMatrix. Or rather that if it is, it should be treated using Matrix behavour, rather than Table behavour. I think that is sound.

codecov[bot] commented 4 years ago

Codecov Report

Merging #15 into master will increase coverage by 0.56%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   97.61%   98.18%   +0.56%     
==========================================
  Files           1        1              
  Lines          42       55      +13     
==========================================
+ Hits           41       54      +13     
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35342e2...7cb0c13. Read the comment docs.