search

invenia / PDMatsExtras.jl

Extra Positive (Semi-)Definite Matricies
MIT License
8 stars 6 forks source link

Extend Woodbury multiplication to Diagonals #14

Closed AlexRobson closed 3 years ago

AlexRobson commented 3 years ago

Defines these methods ensuring that the result doesn't densify. 

*(a::WoodburyPDMat, c::Diagonal{T})
*(c::Diagonal{T}, a::WoodburyPDMat)
*(c1::Diagonal{T}, a::WoodburyPDMat, c2::Diagonal{T})
codecov[bot] commented 3 years ago

Codecov Report

Merging #14 (9fb26b8) into master (160fc34) will increase coverage by 0.77%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   66.66%   67.44%   +0.77%     
==========================================
  Files           3        3              
  Lines          87       86       -1     
==========================================
  Hits           58       58              
+ Misses         29       28       -1
Impacted Files Coverage Δ
src/woodbury_pd_mat.jl 93.75% <100.00%> (+0.41%) :arrow_up:
src/psd_mat.jl 50.94% <0.00%> (-0.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 160fc34...aab28e4. Read the comment docs.

mzgubic commented 3 years ago

don't forget to register at https://juliahub.com/ui/Home