search

invenia / PDMatsExtras.jl

Extra Positive (Semi-)Definite Matricies
MIT License
8 stars 6 forks source link

Add Positive Definate Woodbury #2

Closed oxinabox closed 3 years ago

oxinabox commented 3 years ago

First commit. First commit is just the old close-source code.

Only real change is to use ChainRulesCore rather than Zygote to make non-differnetiable. Some updates to the tests.

Particular fiddly was realising that their was a breaking change in Distributions 0.23.8->0.23.9 that snuck though. https://github.com/JuliaStats/Distributions.jl/pull/1160

codecov-io commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f14d32b). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   62.82%           
=========================================
  Files             ?        3           
  Lines             ?       78           
  Branches          ?        0           
=========================================
  Hits              ?       49           
  Misses            ?       29           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f14d32b...d042e64. Read the comment docs.

oxinabox commented 3 years ago

CI is only failing on nightly, because Zygote doesn't work on nightly