search

invenia / Parallelism.jl

A library for threaded and distributed parallelism.
MIT License
8 stars 1 forks source link

fix tests on 1.8 #13

Closed ericphanson closed 2 years ago

ericphanson commented 2 years ago

In 1.8, asyncmap throws CapturedExceptions so the stacktrace doesn't get dropped (https://github.com/JuliaLang/julia/pull/42105). This doesn't break pmap retries (because they get unwrapped) but it does change the exception getting thrown, so it breaks the tests here.

This PR uses the feature from https://github.com/JuliaLang/julia/pull/41888 to test against the error text on 1.8 (since the exception type is just CapturedException).

ericphanson commented 2 years ago

Seems like the CI workflow got disabled

oxinabox commented 2 years ago

Thanks

ericphanson commented 2 years ago

Thanks for maintaining parallelism! I use a modified version of robust_pmap (I changed up the logging) & copied the tests, which is why I learned they were failing on 1.8 (since my version's tests started failing). (And in a fun coincidence the change upstream is due to my PR).