search

invenia / Parallelism.jl

A library for threaded and distributed parallelism.
MIT License
8 stars 1 forks source link

always use a CachingPool with robust_pmap #2

Closed oxinabox closed 4 years ago

oxinabox commented 4 years ago

I am of the opinion that pmap should do so by default also. (https://github.com/JuliaLang/julia/pull/33892/) But this stops closures reserializing for every item. Which if the closure is large could be big. The overhead of using the CachingPool is not large so I don't think there is a downside. The cache will garbage collect everywhere once this goes out of scope

codecov[bot] commented 4 years ago

Codecov Report

Merging #2 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           25        25           
=========================================
  Hits            25        25
Impacted Files Coverage Δ
src/Parallelism.jl 100.00% <ø> (ø)
src/robust_pmap.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdf9336...8a215a0. Read the comment docs.