search

invenia / SyntheticGrids.jl

Julia package for building synthetic power grids
MIT License
28 stars 10 forks source link

Fix PyCall build in CI #16

Closed eperim closed 5 years ago

eperim commented 5 years ago

Changes (likely in PyCall) have made it such that the old master does not pass CI anymore if reran. This should take care of that by upper bounding PyCall and building it properly in Travis.

codecov[bot] commented 5 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #16   +/-   ##
======================================
  Coverage    74.9%   74.9%           
======================================
  Files          10      10           
  Lines         817     817           
======================================
  Hits          612     612           
  Misses        205     205

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05701a3...a8773aa. Read the comment docs.

iamed2 commented 5 years ago

For some reason, on Windows, Python 3.6 is picked, numpy is installed for Python 3.6, then pandapower is installed for Python 2.7 (causing everything to switch to Python 2.7), then at run time it tries to load Python 3.6 again.

eperim commented 5 years ago

On AppVeyor this has been failing for a really long time. Should we care, though? I did have an older version of this running fine locally on Windows before, but it has been ages since I last tried.

iamed2 commented 5 years ago

It's probably fine without it