WIP: initial release - Githubissues

inveniosoftware-attic / invenio-circulation-legacy

https://invenio-circulation.readthedocs.io

GNU General Public License v2.0

4 stars 8 forks source link

WIP: initial release #6

Closed mvesper closed 8 years ago

mvesper commented 8 years ago

Adds a new module called invenio-circulation which handles the circulation of bibliographic items.

coveralls commented 8 years ago

Changes Unknown when pulling 49f785551f8da6f09ee8bbba573bf88436edacf2 on mvesper:official into \ on inveniosoftware:master**.

coveralls commented 8 years ago

Changes Unknown when pulling 96e69aaa3e27b1022a845cb58491d28171181efb on mvesper:official into \ on inveniosoftware:master**.

coveralls commented 8 years ago

Changes Unknown when pulling ae390fd8b8063beed27b90920a89d47ed59fda41 on mvesper:official into \ on inveniosoftware:master**.

coveralls commented 8 years ago

Changes Unknown when pulling 2548a2f0840e4dd10e39f814501a81227efda81a on mvesper:official into \ on inveniosoftware:master**.

coveralls commented 8 years ago

Changes Unknown when pulling ad6bdfc3b90da708d7ca40a733aa5383db09bb6e on mvesper:official into \ on inveniosoftware:master**.

coveralls commented 8 years ago

Changes Unknown when pulling 00d01e487858a49fb4d1c0b3914a6793a7f9716c on mvesper:official into \ on inveniosoftware:master**.

mvesper commented 8 years ago

Hey all @egabancho @kaplun @jalavik @jirikuncar @lnielsen @PXke

I'd like to invite you to review the current state :)

Please take a closer look to:

models.py. The librarians and I propose to follow a library of congress attribute name style for the records
transaction.py. Since most api functions amend a number of entities, there was need for a way to halt indexing for records until one logical operation was finished for all entities.

jirikuncar commented 8 years ago

@mvesper we had musings with @egabancho during orchestration meeting today about next steps.

We would like to invite you to IT where we can help you to make incremental PRs so it's easier for us to understand the module. You can start by creating small PR with backend (models) only. Later we create new modules for REST and UI as we do for the rest of Invenio packages.

jirikuncar commented 8 years ago

Some general notes:

Leave record indexing for site administrators for now.
We should probably match data model as defined in MARC21 holdings (improving DoJSON package?)
Shall we provide API similar to deposit to change states (see publish/edit/discard methods)?

egabancho commented 8 years ago

@mvesper, as @jirikuncar suggested, I think it's better if you make a PR just with the backend stuff (and then we continue building on top of it), it will make things easier for you with things like keeping the test coverage, and definitely the review process will be much faster.

egabancho commented 8 years ago

We should probably match data model as defined in MARC21 holdings (improving DoJSON package?)

:+1:

mvesper commented 8 years ago

We should probably match data model as defined in MARC21 holdings (improving DoJSON package?)

The current PR tries to go in that direction, that is what I meant with library of congress style attributes.

I think it's better if you make a PR just with the backend stuff (and then we continue building on top of it)

The current PR is basically that already. I removed the UI.

We would like to invite you to IT where we can help you to make incremental PRs so it's easier for us to understand the module.

Sounds good :)

coveralls commented 8 years ago

Coverage decreased (-4.9%) to 95.144% when pulling 08831b2a3a80d71d40300b1a9f584a459f87ee69 on mvesper:official into 6bd44e40cd3f479530c57f24344e91598494c12d on inveniosoftware:master.

jirikuncar commented 8 years ago

@mvesper @PXke I'm closing the PR since the implementation has changed in other PRs.