search

inveniosoftware-attic / jsonalchemy

JSONAlchemy
GNU General Public License v2.0
0 stars 10 forks source link

parser: fix setting default value for dicts #5

Closed MSusik closed 9 years ago

MSusik commented 9 years ago

The same as : https://github.com/inveniosoftware/invenio/pull/2749

jirikuncar commented 9 years ago

@MSusik FYI it's waiting for @egabancho's review.

jmartinm commented 9 years ago

This PR seems to be blocking the inclusion of the author model in INSPIRE https://github.com/inspirehep/inspire-next/pull/170 is there something else to be done or should it be merged?

tiborsimko commented 9 years ago

is there something else to be done or should it be merged?

IIRC @egabancho asked for a test case, which I'd fully second. It's the best way to keep things working over longer term. TDD rocks :smile:

MSusik commented 9 years ago

Sorry, I was quite busy lately. I will create a testcase today in the afternoon.

MSusik commented 9 years ago

Added a test.

jirikuncar commented 9 years ago

@MSusik after discussion with @jalavik we would like to integrate the same patch for invenio:maint-2.0 and jsonalchemy as it's not clear how quickly we progress with pythonic dsl implementation.

MSusik commented 9 years ago

@jirikuncar As requested, I rebased in both places. Also, I removed one of the commits, which added a change to a code, which was already handled by @egabancho .