Stop interfering with the logging level (closes #22)

inveniosoftware-contrib / workflow

Simple Pythonic Workflows

https://workflow.readthedocs.io

Other

152 stars 46 forks source link

Stop interfering with the logging level (closes #22) #23

Closed romanchyla closed 10 years ago

jirikuncar commented 10 years ago

@romanchyla I've added PEP8 check as part of travis test, that's why is failing ;)

romanchyla commented 10 years ago

fixed, it took me longer because i'm on Windows (eeek) and had to figure how to run tests (the default python setup.py test runs all python tests)

romanchyla commented 10 years ago

well, this is aggravating - it fails on python3 and i don't even have how to test it on this machine; it will have to wait till later.... i assume unicode....

tiborsimko commented 10 years ago

@romanchyla Just a side note: if you are "stuck" on a Windows machine, you may want to try Vagrant, there are easy-to-use officially published Ubuntu 14.04 LTS "trusty" boxes like http://cloud-images.ubuntu.com/vagrant/trusty/20140813/trusty-server-cloudimg-amd64-vagrant-disk1.box, coming with Python-2.7 and Python-3.4.

jirikuncar commented 10 years ago

@romanchyla please see my improvements: https://github.com/jirikuncar/workflow/compare/pr/23

update: btw I have amended commit messages. If you are ok with it please merge my branch.

coveralls commented 10 years ago

Coverage increased (+0.07%) when pulling 9d7963066aa060f883ae6b5f8979e1ed8bc9e624 on logging-fix into e165607292cfdcdd4d9f0145f6b3a7230ec77f9a on master.