Global support for datacite 4.0

remileduc commented 8 years ago

FIX https://github.com/inveniosoftware/datacite/issues/15

done:

create schema40.py
create JSON schema for v4.0
create basic tests for v4.0
change the tests for specific fields in v4.0
update documentation

not done yet:

refactor code to factorize common rules between v3.1 and v4.0 -> should it be part of another PR?

what is done: Fully working and tested support for v4.0 (main test with full JSON example works).

FIX

affiliation field is now an array for both creators and contributors

Hint for CR On this PR, the changelog of github is not very nice... You can manually look at the diffs between the following files to see what has been modified:

schema31.py and schema40.py
datacite-v3.1.json and datacite-v4.0.json
datacite-v3.1-full-example.json and datacite-v4.0-full-example.json
test_schema31 and test_schema40

jirikuncar commented 8 years ago

@remileduc the refactoring can be done later if we have good test coverage.

lnielsen commented 8 years ago

@remileduc I agree with @jirikuncar. Also, "refactor tests to factorize common rules" is not needed. I think it's actually better to have tests for 4.0 and 3.1 split.

lnielsen commented 7 years ago

LGTM

inveniosoftware / datacite

Global support for datacite 4.0 #18