Closed ethanhs closed 7 years ago
@ethanhs the README.rst
looks good. The idea behind #17 was to also update docs/index.rst
and docs/conf.py
(setup.py
for Sphinx
version) according to our latest Cookiecutter template so we can fully close it. Otherwise, I can just squash merge and amend the commit messages to follow our organization style and use (addresses #17)
instead of Resolves
.
Ah, I see. I'll close this PR and open a new one that resolves #17 as you desire.
@ethanhs you can force push to the same branch. There is no need in closing the PR.
@jirikuncar Go ahead and squash merge and I've changed resolves to addresses.
LGTM
Addresses #17
Let me know if you want any tweaks to the order etc.