Closed tmorrell closed 7 months ago
@edager do you have a second to review this PR? It will fix the CI so we can start working on 4.5
Hi @tmorrell,
Sure, I can have a look if you want, however I'm still not completely familiar with how this implementation of the connection to datacite works, just so you're warned.
It's a two line change to make the tests work again. I just need someone else to review before I merge. Thanks!
Looks completely reasonable to me that there shouldn't be any content in the body when testing a 204 error. Can you add my as reviewer?
GitHub didn't allow me to add you as a reviewer...so I'll take your comment as a positive review
:heart: Thank you for your contribution!
Description
Fix 204 error in tests so CI works
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: