search

inveniosoftware / datacite

Python API wrapper for the DataCite API.
https://datacite.readthedocs.io
Other
27 stars 33 forks source link

uniqueItems usage does not appear to correpond to XSD restrictions #86

Open edager opened 7 months ago

edager commented 7 months ago

Package version (if known): 1.1.3

Describe the bug

uniqueItems does not appear to be justified in the arrays in the json schemas where it is currently used (e.g. creators) . As far as I can tell, there are no such restrictions posed by the XSD.

Expected behaviour

Identical elements in the same array should be allowed as far as I can tell.

Additional context

In particular for creators, this would prevent people with the same name and no orcid from publishing together (I know, not super common).

tmorrell commented 2 months ago

This should be fixed in the 4.5 schema. I'd lean toward leaving the 4.3 schema as-is unless someone really needs it.