search

inveniosoftware / docker-invenio

Docker base images for Invenio.
https://docker-invenio.readthedocs.io
MIT License
10 stars 34 forks source link

docker: xrootd base image #20

Open lnielsen opened 5 years ago

lnielsen commented 5 years ago

Create a base image from inveniosoftware/centos7-python with XRootD libraries included.

Usage:

FROM inveniosoftware/centos7-python:3.6-xrootd
# ...
ntarocco commented 4 years ago

@lnielsen I think there is an issue here. We have created an image: inveniosoftware/centos7-python with a tag 3.6, but the 3.6 python version is hardcoded in the image. I also saw that @fenekku created a python3.7 one, I guess we will have to publish that one too at some point. Would I would expect probably is to have something like:

Link: https://hub.docker.com/u/inveniosoftware

lnielsen commented 4 years ago

I'm not the right one to answer. Back in the days, I remember we thought that it was the python version you would want to change, similar to

FROM python:3.8

I think 3.6 was hardcoded because it was not possible to get 3.7 via rpms at that point

lnielsen commented 4 years ago

See https://github.com/inveniosoftware/docker-invenio/blob/master/python3.7/Dockerfile

diegodelemos commented 4 years ago

Regarding the Docker image name, there was a long discussion on GitHub and real-life (see for reference https://github.com/inveniosoftware/docker-invenio/issues/1#issue-343638646 and https://github.com/inveniosoftware/docker-invenio/pull/6#discussion_r212348438e) which ended up in the compromise with we have right now, if we want to change it again I have nothing against.

ntarocco commented 4 years ago

Blocked by: https://github.com/inveniosoftware/invenio-xrootd/issues/23