search

inveniosoftware / dojson

Simple pythonic JSON to JSON converter.
https://dojson.readthedocs.io
Other
10 stars 29 forks source link

utils: addition of script utils #153

Closed blixhavn closed 8 years ago

blixhavn commented 8 years ago

Signed-off-by: Øystein Blixhavn oystein@blixhavn.no

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 82.775% when pulling c92c1a7ec7a08963299cf1e470baf205b45cab79 on blixhavn:blixhavn/add-scripts into aa1bf54a9f61899c92b36edcf8e52eaa5ab31b3d on inveniosoftware:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 82.775% when pulling 44f9ce101a7a56b55f99f5822d725b5f347bf7b9 on blixhavn:blixhavn/add-scripts into aa1bf54a9f61899c92b36edcf8e52eaa5ab31b3d on inveniosoftware:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 82.775% when pulling 3c1e76b3be828383b9173c2d0bf966b66df8080c on blixhavn:blixhavn/add-scripts into ada2d71ee8f94b2c4379c566cee40c8d4052e502 on inveniosoftware:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 82.775% when pulling 3c1e76b3be828383b9173c2d0bf966b66df8080c on blixhavn:blixhavn/add-scripts into ada2d71ee8f94b2c4379c566cee40c8d4052e502 on inveniosoftware:master.

blixhavn commented 8 years ago

@jirikuncar What's your stance on the exec call in this PR? It breaks QuantifiedCode, but I'm hesitant to rewrite my script to avoid it. As this is just a utility script, I don't see the imminent security risk.

tiborsimko commented 8 years ago

scripts/utils_create_xml.py is too generic a name for my taste. DoJSON is meant to be doing lots of things, marc21 is just one of contrib things. We may have later ead, pcdm, and whatnot other parsers. Hence the helper scripts should be at the very least named in an appropriate manner, e.g. marc21_add_order, marc21_filter_fields, and whatnot. Also, they may be perhaps better living under the contrib directory, since they are not strictly speaking DoJSON-wide applicable, but rather contrib/marc specific...

jirikuncar commented 8 years ago

@tiborsimko it can live under /scripts/contrib/marc21/... but definitely not inside /dojson Python package.

jirikuncar commented 8 years ago

IMHO these utility functions can live outside the repo. If there is a wider interest we can re-open this PR.