search

inveniosoftware / dojson

Simple pythonic JSON to JSON converter.
https://dojson.readthedocs.io
Other
10 stars 29 forks source link

global: addition of .editorconfig #164

Closed jirikuncar closed 8 years ago

jirikuncar commented 8 years ago

Signed-off-by: Jiri Kuncar jiri.kuncar@cern.ch

tiborsimko commented 8 years ago

.editorconfig is missing in MANIFEST.in.

BTW it may be better to use docs: addition of ... because these are more "documentation" oriented changes, rather than "global" code base changes.

jirikuncar commented 8 years ago

@tiborsimko .editorconfig is more about "global" package style.

tiborsimko commented 8 years ago

@tiborsimko .editorconfig is more about "global" package style.

If you fix the global code base style to conform to these settings at the same time, then yes.

(Otherwise it'd be only a "documentation" like commit, similarly to suggesting the usage of PEP-8 or PEP-257 without changing the global code base itself -- that's what I meant.)

Changes to AUTHORS.rst file are more clearly "documentation" oriented, as they don't touch "global" code base at all.

jirikuncar commented 8 years ago

IMHO it's not "only" a documentation, but I've changed it.