global: removal of six, support for python -m dojson, testing PyPy

inveniosoftware / dojson

Simple pythonic JSON to JSON converter.

https://dojson.readthedocs.io

Other

10 stars 29 forks source link

global: removal of six, support for python -m dojson, testing PyPy #166

Closed jirikuncar closed 8 years ago

kaplun commented 8 years ago

To better understand:

what is the reason for removing six? Aren't we ending up reimplementing six into the _compat.py?
is this going to be part of an horizontal removal of six everywhere?

jirikuncar commented 8 years ago

@kaplun six is nice for quick compatibility, but if we are using only limited set of features it is a bit overkill. It's usually possible to write compatible PY2/3 code without using six or python version detection.

tiborsimko commented 8 years ago

The releases of six are not very frequent, which is good, but we may have to watch for any future e.g. security related updates, if some of our packages are going to use a lot of six. Otherwise we should be good.

Perhaps leave a comment in _compat.py saying the code was inspired/borrowed from six? And, for Invenio standalone packages, we can perhaps centralise some stuff in a common package? (Invenio-Base?)