contrib: fix of 044 being repeatable

inveniosoftware / dojson

Simple pythonic JSON to JSON converter.

https://dojson.readthedocs.io

Other

10 stars 29 forks source link

Closed blixhavn closed 7 years ago

blixhavn commented 7 years ago

FIX Removes @utils.for_each_value decorator from conversion function for marc field 044, which is not repeatable. (closes #181)

Signed-off-by: Øystein Blixhavn oystein@blixhavn.no

jirikuncar commented 7 years ago

@blixhavn can you check JSON schema too?

Update: do we have a specific (regression) test for this fields?

blixhavn commented 7 years ago

The schema seems to be correct

blixhavn commented 7 years ago

This field is apparently tested in dojson/tests/data/library_of_congress/bd01x09x.xml and dojson/tests/data/test_8.xml

jirikuncar commented 7 years ago

@blixhavn please check the failing test case.

jirikuncar commented 7 years ago

LGTM