search

inveniosoftware / dojson

Simple pythonic JSON to JSON converter.
https://dojson.readthedocs.io
Other
10 stars 29 forks source link

RFC is 'Undo' still experimental #194

Closed switowski closed 7 years ago

switowski commented 7 years ago

Due to https://github.com/inveniosoftware/dojson/blob/master/dojson/contrib/to_marc21/model.py#L21 we get the following warnings:

.../dojson/contrib/to_marc21/model.py:21: UserWarning: MARC21 undo feature is experimental
  warnings.warn('MARC21 undo feature is experimental')

Is this feature still experimental? Should we remove the warning? I see that it's used on Zenodo: https://github.com/zenodo/zenodo/blob/master/zenodo/modules/records/serializers/to_marc21/model.py#L33 and on CDS it was recently removed: https://github.com/CERNDocumentServer/cds-dojson/commit/0e51c3209776c3fbb2fa131b9c6463d293913855#diff-6769d5bc9abff7a2879ee1c4395cda20

@lnielsen @egabancho WDYT?

lnielsen commented 7 years ago

Let's remove the warning. It's used in extensively in production and it might be that it will need changes in the future, but it's not helpful to see the error message every single time you run. The same can be singled in the documentation and via version numbers.

egabancho commented 7 years ago

cc @blixhavn

blixhavn commented 7 years ago

I agree with Lars. We've never had any problems with the undo feature (sorry about the delay, I was on vacation).