search

inveniosoftware / dojson

Simple pythonic JSON to JSON converter.
https://dojson.readthedocs.io
Other
10 stars 29 forks source link

marc21: complete `856` conversion function #40

Closed egabancho closed 9 years ago

egabancho commented 9 years ago

Signed-off-by: Esteban J. G. Gabancho esteban.gabancho@gmail.com

jirikuncar commented 9 years ago

https://github.com/inveniosoftware/dojson/pull/40/files#diff-6b317341feced1ca6409d2db2b4914d0R131 subfield 2 should be used only if the indicator is 7 (see http://www.loc.gov/marc/bibliographic/concise/bd856.html)

egabancho commented 9 years ago

ping @jirikuncar

jirikuncar commented 9 years ago

@egabancho it looks good. can you also provide a test case?

egabancho commented 9 years ago

I was writing the tests!

jirikuncar commented 9 years ago

:+1: - can you extract them to new PR?