global: addition of ignore missing option

inveniosoftware / dojson

Simple pythonic JSON to JSON converter.

https://dojson.readthedocs.io

Other

10 stars 29 forks source link

Closed jirikuncar closed 8 years ago

jirikuncar commented 8 years ago

NEW Adds ignore_missing option to Overdo.do method to specify if method should raise when there is no matching rule for any key. (closes #51)

Signed-off-by: Jiri Kuncar jiri.kuncar@cern.ch

tiborsimko commented 8 years ago

Can you please look at the failed test cases? (4 failed, 94 passed)
The commit log message should probably speak about the CLI argument name which is --strict. Unless we harmonise the CLI API argument name and the Python API argument name, which would be even better...
Also, the commit message now says "should raise when...". This could be made more explicit e.g. "should raise MissingRule exception when..."

greut commented 8 years ago

Nice!