search

inveniosoftware / dojson

Simple pythonic JSON to JSON converter.
https://dojson.readthedocs.io
Other
10 stars 29 forks source link

dojson: field ordering fixes #76

Closed SamiHiltunen closed 8 years ago

SamiHiltunen commented 8 years ago

Co-authored-by: Jiri Kuncar jiri.kuncar@cern.ch Signed-off-by: Sami Hiltunen sami.mikael.hiltunen@cern.ch

switowski commented 8 years ago

Blocked by #78

switowski commented 8 years ago

How about putting all TIND test records in one file ? Having 16 test files seems to be too much and it will become unmanageable.

switowski commented 8 years ago

Otherwise LGTM and we can :shipit:

SamiHiltunen commented 8 years ago

Is this '-vv' needed ?

I'd say this is needed. Having -vv will show the full diff for failing identity tests. This way we can see what is failing in the tests also on Travis. I relocated the flags from run-tests.sh to pytest.ini.

Could you, please order the packages alphabetically ? Can you please change commit message: FIX Order of datafields is now kept. -> keeps the order of datafields FIX Orderings of several subfields are now preserved. -> preserves the order of subfields

Fixed both. :+1: