inveniosoftware / dojson

Simple pythonic JSON to JSON converter.
https://dojson.readthedocs.io
Other
10 stars 29 forks source link

test: demo MARC21 data from CDS #81

Closed switowski closed 8 years ago

switowski commented 8 years ago
switowski commented 8 years ago

TODO:

switowski commented 8 years ago

I have prepared an example record with fields that @SamiHiltunen was missing in https://github.com/inveniosoftware/dojson/issues/78. @egabancho can you take a look and merge ?

switowski commented 8 years ago

Thanks for spotting all those errors @SamiHiltunen ! As for removing those 'no information provided' and similar indicators, I wouldn't do this. Not always _ has an obvious meaning, for example here: https://www.loc.gov/marc/bibliographic/concise/bd210.html it actually have a completely different meaning.

tiborsimko commented 8 years ago

Note that this commit updates field rules, but does not update schemas. The danger is that they may get out of sync...

dojson/contrib/marc21/fields/bd3xx.py
dojson/contrib/marc21/schemas/bd3xx.json
switowski commented 8 years ago

Valid point. https://github.com/inveniosoftware/dojson/issues/84 should catch those issues in the future.