INVENIO_DATACITE_ENABLED is "false" instead of "False" leading to a bad python evaluation

[avivace]

We are using .Values.invenio.datacite.enabled both as a flag (e.g. to decide when to inject the datacite credentials) and as the value to be injected as INVENIO_DATACITE_ENABLED in the invenio config map (which feeds the environment). However, YAML's boolean false gets evaluated to true in python, leading to a messed up configuration (e.g. try to deploy the helm charts with the default values, datacite comes up as enabled because INVENIO_DATACITE_ENABLED is set as false and not False in the configMap).

[avivace]

Option 1:

• Use the values from values.yaml as guards and manually set the invenio-config values to "True or False"

Option 2:

• Use "True" or "False" in the yaml (see https://yaml.org/type/bool.html) - currently checking this solution

[avivace]

Currently waiting for some feedback - should this be escalated to invenio-config and how we parse invenio.cfg?

[kpsherva]

could it be because of the quote marks around the value? it gets evaluated as string and then as true. Did you test without the quotes?