This change refactors the directory structure for the Invenio Helm chart. This includes:
Moving invenio/ into charts/
Rename job-install --> install-init-job
Moving services into subdirectories by app
Moving PVCs into directories by app
Moving deployments into directories by app
Moving configurations to directories by app
For more details on each move, please read the individual commit messages.
I appreciate that this change can be difficult to review. One way to review this PR is to check for changes in the rendered manifests. If I have done everything right in this PR, there should be no diff to the rendered manifests before and after these changes. You can verify this the following way, using dyff for semantic YAML diff:
I have verified the above example. If you want to check using some particular set of values, please help me do that.
I have tried to look through the README for references to specific files, which would need to be updated. I didn't find any, but I might have missed them.
Fixes #84
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Great! I agree, when moving to external dependencies, things will move around more. Actually, I think with this setup, it will be even cleaner to remove each dependency!
:heart: Thank you for your contribution!
Description
This change refactors the directory structure for the Invenio Helm chart. This includes:
For more details on each move, please read the individual commit messages.
I appreciate that this change can be difficult to review. One way to review this PR is to check for changes in the rendered manifests. If I have done everything right in this PR, there should be no diff to the rendered manifests before and after these changes. You can verify this the following way, using dyff for semantic YAML diff:
I have verified the above example. If you want to check using some particular set of values, please help me do that.
I have tried to look through the README for references to specific files, which would need to be updated. I didn't find any, but I might have missed them.
Fixes #84
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge: