inveniosoftware / helm-invenio

Helm charts for deploying an Invenio instance
https://helm-invenio.readthedocs.io
7 stars 20 forks source link

Refactor directory structure of Invenio Helm chart #91

Closed lindhe closed 11 months ago

lindhe commented 11 months ago

:heart: Thank you for your contribution!

Description

This change refactors the directory structure for the Invenio Helm chart. This includes:

For more details on each move, please read the individual commit messages.

I appreciate that this change can be difficult to review. One way to review this PR is to check for changes in the rendered manifests. If I have done everything right in this PR, there should be no diff to the rendered manifests before and after these changes. You can verify this the following way, using dyff for semantic YAML diff:

$ git switch master
$ helm template ./invenio > before.yaml
$ git switch lindhe/restructure-templates
$ helm template ./charts/invenio > after.yaml
$ dyff between --ignore-order-changes before.yaml after.yaml
     _        __  __
   _| |_   _ / _|/ _|  between before.yaml, 26 documents
 / _' | | | | |_| |_       and after.yaml, 26 documents
| (_| | |_| |  _|  _|
 \__,_|\__, |_| |_|   returned no differences
        |___/

I have verified the above example. If you want to check using some particular set of values, please help me do that.

I have tried to look through the README for references to specific files, which would need to be updated. I didn't find any, but I might have missed them.

Fixes #84

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

lindhe commented 11 months ago

Great! I agree, when moving to external dependencies, things will move around more. Actually, I think with this setup, it will be even cleaner to remove each dependency!

Please merge when you see fit.