inveniosoftware / helm-invenio

Helm charts for deploying an Invenio instance
https://helm-invenio.readthedocs.io
7 stars 19 forks source link

chart: Split worker-deployment.yaml and routes.yaml #94

Closed lindhe closed 8 months ago

lindhe commented 10 months ago

:heart: Thank you for your contribution!

Description

This change splits the routes.yaml and worker-deployment.yaml into multiple files. Should have been part of #91 but we missed it.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
slint commented 8 months ago

This seems to have merge conflicts now, if you can have a quick look it's good to merge.

lindhe commented 8 months ago

Thanks! I'll check it!

lindhe commented 8 months ago

Considering there is a Route for RabbitMQ, which we will touch on in #100, should we drop that part of this change for now and handle it after #100 is merged?

slint commented 8 months ago

Considering there is a Route for RabbitMQ, which we will touch on in #100, should we drop that part of this change for now and handle it after #100 is merged?

Fine with me, feel free to change/close this PR as needed đź‘Ť

lindhe commented 8 months ago

There. I think we'll leave it at this for the time being, and split more files later, after the dependencies are replaced.

lindhe commented 8 months ago

WIP: Don't merge yet!

lindhe commented 8 months ago

Alright, ready to merge now!