query filter creation should not happen in the ui layer - Githubissues

inveniosoftware / invenio-app-rdm

Turn-key research data management platform.

https://inveniordm.docs.cern.ch

MIT License

100 stars 144 forks source link

query filter creation should not happen in the ui layer #1010

Open ppanero opened 3 years ago

ppanero commented 3 years ago

In order to address this https://github.com/inveniosoftware/invenio-rdm-records/issues/760 issue. A query filter was added in the view (here and here). However, this should only happen at service level (e.g. a change in the backend technology - Elasticsearch - should not impact the UI. I am not saying this change is likely to happen) to have a clear separation of concerns.

Possible solutions:

Add a method to the current RDM-records service
Add a sub-service that inherits from invenio-vocabularies.service. (the funcitonality is RDM related, and not generic enough for it to go to invenio-vocabularies).

github-actions[bot] commented 2 years ago

This issue was automatically marked as stale.