Closed fenekku closed 2 years ago
Hi, I noticed that but actually thought it was pre-existing. Seems like the classname, "inline-orcid," should be "inline-id-icon." Will have a look.
I am looking here - -
https://github.com/inveniosoftware/react-invenio-deposit/blob/2809aae10495cffb65a8a3a19c14e1030fafc1c6/src/lib/components/Creatibutors/CreatibutorsFieldItem.js#L113
Does that seem like the right bit to update?
(That image also wants an alt tag btw)
That sounds like the right component. The class name or css might have been changed. Try it out! :)
Hi @fenekku PR is here -- https://github.com/inveniosoftware/react-invenio-deposit/pull/404 Added the classname "inline-id-icon" which is used elsewhere (https://github.com/inveniosoftware/invenio-app-rdm/commit/3d2d1702c14c2cde1929dc56c31b8b3870b3b1ed#diff-03c62dcb6d10432401c4c9e596011286cb37d5674577bbb04fa464921d2ee6f0R16) Hard-coded the height and width to conform to ORCID branding requirements https://info.orcid.org/brand-guidelines/#Example_HTML And a wrapper span for flexible styling options and consistency with creatributors elsewhere
Package version (if known): v7
Describe the bug
When filling out the deposit page, entering an ORCID identifier and saving the draft, the ORCID icon shows up oversized:
(this was achieved on the CERN demo site on 2021-12-10)
Steps to Reproduce
Expected behavior
A normal size ORCID id.
I suspect it has to do with some accessibility changes.