search

inveniosoftware / invenio-app-rdm

Turn-key research data management platform.
https://inveniordm.docs.cern.ch
MIT License
108 stars 149 forks source link

Deposit page ORCID icon is oversized #1144

Closed fenekku closed 2 years ago

fenekku commented 2 years ago

Package version (if known): v7

Describe the bug

When filling out the deposit page, entering an ORCID identifier and saving the draft, the ORCID icon shows up oversized:

image (this was achieved on the CERN demo site on 2021-12-10)

Steps to Reproduce

  1. Go to '/uploads/new'
  2. Fill out creators with an ORCID id (the id is valid)
  3. Click save draft (other fields were filled correctly)
  4. See error

Expected behavior

A normal size ORCID id.

I suspect it has to do with some accessibility changes.

lhenze commented 2 years ago

Hi, I noticed that but actually thought it was pre-existing. Seems like the classname, "inline-orcid," should be "inline-id-icon." Will have a look.

lhenze commented 2 years ago

I am looking here - - https://github.com/inveniosoftware/react-invenio-deposit/blob/2809aae10495cffb65a8a3a19c14e1030fafc1c6/src/lib/components/Creatibutors/CreatibutorsFieldItem.js#L113 Does that seem like the right bit to update?
(That image also wants an alt tag btw)

fenekku commented 2 years ago

That sounds like the right component. The class name or css might have been changed. Try it out! :)

lhenze commented 2 years ago

Hi @fenekku PR is here -- https://github.com/inveniosoftware/react-invenio-deposit/pull/404 Added the classname "inline-id-icon" which is used elsewhere (https://github.com/inveniosoftware/invenio-app-rdm/commit/3d2d1702c14c2cde1929dc56c31b8b3870b3b1ed#diff-03c62dcb6d10432401c4c9e596011286cb37d5674577bbb04fa464921d2ee6f0R16) Hard-coded the height and width to conform to ORCID branding requirements https://info.orcid.org/brand-guidelines/#Example_HTML And a wrapper span for flexible styling options and consistency with creatributors elsewhere

fenekku commented 2 years ago

Closed by https://github.com/inveniosoftware/react-invenio-deposit/pull/404