Problem

The following strings aren't marked nicely for translation:

The problem is, that the strings for translation get cut in parts. For example:

p1 = For more tips, check out our p2 = search guide p3 = for defining advanced search queries

Note the white space at the end of p1 and at the beginning of p3. Since word order in languages are different and the translator will see the strings separated from each other - it is hard to translate them properly and not mess up with white spaces. Is is also sensible to include the dots at the end of sentences within the marked strings since this can also be a relevant part of translation or depending on the language.

Solution

Probably this way of marking translations would fix (some of) the strings?

https://github.com/inveniosoftware/invenio-communities/blob/2da66f3c478c7745b6fbcaee2b0b48d26523f58c/invenio_communities/assets/semantic-ui/js/invenio_communities/members/invitations/invitationsModal/GroupTabPane.js#L115-117
See also: https://inveniordm.docs.cern.ch/develop/best-practices/i18n/ (search for Trans) Comments by @kpsherva:
https://react.i18next.com/latest/trans-component
there are also examples in the code with something like i18next.t("ABC {{ not_translatable_variable }} rest of the string", {not_translatable_variable: 7}) it might be also useful to see

Subissue of #1707

inveniosoftware / invenio-app-rdm

i18n: Improvement of strings marked for translation needed #1718

Problem

Solution