search

inveniosoftware / invenio-app-rdm

Turn-key research data management platform.
https://inveniordm.docs.cern.ch
MIT License
100 stars 144 forks source link

Can't overwrite footerLightColor in instance's site.variables. #2077

Open fenekku opened 1 year ago

fenekku commented 1 year ago

Package version (if known): v11.0

Describe the bug

Setting @footerLightColor in my instance's assets/less/site/globals/site.variables doesn't override the footerLightColor defined in invenio-app-rdm (https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/theme/assets/semantic-ui/less/invenio_app_rdm/theme/globals/site.variables#L37). According to https://inveniordm.docs.cern.ch/customize/look-and-feel/theme/#step-by-step the instance override should take effect.

Steps to Reproduce

  1. Edit your instance's site.variables with the variable you want to overwrite.
  2. Run invenio-cli assets build
  3. See error in color of the footer

Expected behavior

site.variables overridden variables take precedence.

Additional context

This probably affects other variables.

github-actions[bot] commented 1 year ago

This issue was automatically marked as stale.