search

inveniosoftware / invenio-app-rdm

Turn-key research data management platform.
https://inveniordm.docs.cern.ch
MIT License
96 stars 138 forks source link

Support custom funders in deposit form #2226

Open tmorrell opened 1 year ago

tmorrell commented 1 year ago

Package version (if known): v9-v12b1

Describe the bug

A custom award should support custom funders, as described in the metadata schema and supported in the API. However, the autocomplete dropdown is not configured to allow users to add a custom funder. This should function the same as affiliations.

Steps to Reproduce

  1. Go to Funding, Add Custom
  2. Try to add a funder that's not in ROR, like "CustomFunder"
  3. Screen says "No results found", with no option to add a funder

Expected behavior

An "Add CustomFunder" should be in the dropdown, like affiliations

Additional context

https://github.com/caltechlibrary/invenio-vocabularies/blob/1f3adfe1f24b392655798f868d857db2e57f23af/invenio_vocabularies/assets/semantic-ui/js/invenio_vocabularies/src/contrib/forms/Funding/CustomAwardForm.js#L74

needs to be modified to be like https://github.com/inveniosoftware/invenio-rdm-records/blob/99f4430f285ebcacf8186eb46de4d797f2be562f/invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/fields/AffiliationsField/AffiliationsField.js#L16

Sadly just switching allowAdditions to true doesn't solve the problem. The custom funder shows up multiple times in the dropdown, so more modifications will be needed.

github-actions[bot] commented 12 months ago

This issue was automatically marked as stale.

github-actions[bot] commented 1 month ago

This issue was automatically marked as stale.