search

inveniosoftware / invenio-app-rdm

Turn-key research data management platform.
https://inveniordm.docs.cern.ch
MIT License
96 stars 140 forks source link

Incorrect error handling in resource layer #2539

Open jrcastro2 opened 8 months ago

jrcastro2 commented 8 months ago

At the moment we are catching low levels exceptions suchs as NoResultFound in the resource layer, that can potentially hide issues. The service layer should catch the exception when resolving the record and raise a proper error that can be caught in the resource layer.

See here example: https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/records_ui/views/decorators.py#L175

Here original comment: https://github.com/inveniosoftware/invenio-rdm-records/pull/1604/files#r1394256328

github-actions[bot] commented 6 months ago

This issue was automatically marked as stale.

github-actions[bot] commented 4 months ago

This issue was automatically marked as stale.