inveniosoftware / invenio-app-rdm

Turn-key research data management platform.
https://inveniordm.docs.cern.ch
MIT License
110 stars 149 forks source link

records/macros/detail.html: Allow funding entry with award number only #2912

Open karkraeg opened 1 week ago

karkraeg commented 1 week ago

:heart: Thank you for your contribution!

Description

In order to display funding entries with only an award number after https://github.com/inveniosoftware/invenio-vocabularies/pull/429 has been merged this PR changes the display logic.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.
karkraeg commented 1 week ago

Funder + Number

image

Two funding entries, second one with URL

image

No award number

image

Award number + title

image

Only award number

image

Just a funder name

image

karkraeg commented 5 days ago

Hi @tmorrell , is this the way you were thinking?

tmorrell commented 4 days ago

Could you add one or two screenshots?

wgresshoff commented 4 days ago

Perhaps the wrong place here (surely the wrong place here!) but it's just a thought: did someone bother to look if the change has implications on OAI-PMH output? If the transformers rely on number AND title instead of number OR title?!

tmorrell commented 3 days ago

@wgresshoff Funding isn't serialized in the default dc oai output. The DataCite output should be alright assuming I understand how missing is working. @karkraeg if you've got a test instance up it would be worth running through the export formats on an example record and making sure they don't break.