checkout: allow exception for active loans - Githubissues

inveniosoftware / invenio-circulation

Library circulation module for Invenio.

https://invenio-circulation.readthedocs.io

MIT License

0 stars 18 forks source link

checkout: allow exception for active loans #124

Closed BadrAly closed 4 years ago

BadrAly commented 4 years ago

Adds option to consider the at_desk item as available.
if checked_patron is the owner of the exceptions loan.

Co-Authored-by: Olivier Dossmann git@dossmann.net Co-Authored-by: Aly Badr aly.badr@rero.ch

blankoworld commented 4 years ago

Finally we found that ITEM_AT_DESK can behave differently via transitions. The behaviour from ITEM_AT_DESK to ITEM_ON_LOAN should be different here: https://github.com/inveniosoftware/invenio-circulation/blob/c3fcc1a4674d5df24221e3c068e8e0c07db68016/invenio_circulation/transitions/transitions.py#L160

As we make a chart in relation with CERN and RERO here: https://github.com/rero/rero-ils/blob/master/doc/circulation_statechart/circulation_loan_statechart.pdf

I think something is possible that is compatible with CERN behaviour and RERO behaviour.

I started fixing that here: https://github.com/BadrAly/invenio-circulation/commit/221212211a022b28468742288faae4d1a407ba3a