search

inveniosoftware / invenio-circulation

Library circulation module for Invenio.
https://invenio-circulation.readthedocs.io
MIT License
0 stars 18 forks source link

transitions: fix initial_loan #135

Closed ntarocco closed 4 years ago

blankoworld commented 4 years ago

1/ Regarding the code, it seems to be OK for me 2/ For the commit message, I think that more explanation could useful (to understand why we do this change) 3/ In case of RERO circulation I need to make a test with my colleague today before validating this commit :pray:

blankoworld commented 4 years ago

1/ Regarding the code, it seems to be OK for me 2/ For the commit message, I think that more explanation could useful (to understand why we do this change) 3/ In case of RERO circulation I need to make a test with my colleague today before validating this commit

1/ and 3/ are OK :+1:

Could you please fix 2/ and possibly create a new invenio-circulation version (i.e 1.0.0a26)? Thanks a lot for this quick fix!