api: implement API GET request to fetch a loan

inveniosoftware / invenio-circulation

Library circulation module for Invenio.

https://invenio-circulation.readthedocs.io

MIT License

0 stars 18 forks source link

api: implement API GET request to fetch a loan #34

Closed ntarocco closed 6 years ago

ntarocco commented 6 years ago

added extensions rest, records, records-rest, db, search, pidstore
created basic configuration for REST calls
created test to fetch a loan record
fixed example app

Co-authored-by: Zacharias Zacharodimos zacharias.zacharodimos@cern.ch Co-authored-by: Christos Topaloudis topless@gmail.com

jma commented 6 years ago

You have to sort correctly the import: try isort -rc.

ntarocco commented 6 years ago

@jma unfortunately on my Mac, I have isort not giving same results as Travis, so until I am able to fix it, I always need to wait Travis to see which ones are wrong.. thanks for commenting it but it will happen again :)

jma commented 6 years ago

@ntarocco ok no problem. But when I try to run pytest I got:

Usage: flask fixtures [OPTIONS] COMMAND [ARGS]...

Error: No such command "loans".

ntarocco commented 6 years ago

@jma @Garfield-fr @BadrAly PR is ready!

egabancho commented 6 years ago

What do you think about using python 3.6 instead of 3.5 in Travis?

ntarocco commented 6 years ago

@egabancho yeah no problem! Do you see any particular reason? or it is just to be up-to-date?

egabancho commented 6 years ago

No, nothing special about it, just to stay updated. The last release for 3.5 is planed for August and it’s already in “security fixes” mode already (according to the docs), it seems natural to use 3.6 if possible. Otherwise you can use 3.7, which was release a few days ago 😉